Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REL-554 Set GPG key trust level #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

REL-554 Set GPG key trust level #13

wants to merge 3 commits into from

Conversation

pvinh-spike
Copy link

Add setting GPG key trust level to Ultimate.

Klaven
Klaven approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Klaven Klaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Phuc!

question, should we let people set the trust level? I think you are right, I was just trying to think of the use case here!

anyhow, looks good thanks!

devops/setup-gpg/action.yaml Show resolved Hide resolved
mcoberly2
mcoberly2 approved these changes Nov 12, 2024
View reviewed changes
Copy link

@mcoberly2 mcoberly2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, "I trust ultimately" 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaven Klaven Klaven approved these changes

@mcoberly2 mcoberly2 mcoberly2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvinh-spike @Klaven @mcoberly2